From: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Subject: Re: [PATCH] ALSA driver for SGI O2 audio board Date: Thu, 10 Jul 2008 19:00:11 +0200 Message-ID: <20080710170011.GA8659@alpha.franken.de> References: <20080704234559.C959CFB63A@solo.franken.de> <20080709175059.GA10046@alpha.franken.de> <20080709183138.GA21872@alpha.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by alsa0.perex.cz (Postfix) with ESMTP id 820E924777 for ; Thu, 10 Jul 2008 19:09:12 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, Jul 10, 2008 at 05:52:50PM +0200, Takashi Iwai wrote: > At Wed, 9 Jul 2008 20:31:38 +0200, > Thomas Bogendoerfer wrote: > > > > On Thu, Jul 10, 2008 at 02:15:26AM +0200, Takashi Iwai wrote: > > > At Wed, 9 Jul 2008 19:50:59 +0200, > > > > > If there are shared interrupts, they could be called before the > > > > > initialization below. So, safer to move after the init. > > > > > > > > they can't be shared and it's already done before any hardware init. > > > > > > Then any reason to pass IRQF_SHARED? > > > > of course not. I'll remove it. > > v2 still has it... I know, I've sent it earlier. Just wanted to give v2 a little time, if something else pops up. If everything else is ok, I'll respin a v3 with just the IRQF_SHARED removed. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]