Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 18E14DE9C5 for ; Fri, 18 Jul 2008 00:13:38 +1000 (EST) Date: Thu, 17 Jul 2008 18:13:35 +0400 From: Anton Vorontsov To: Grant Likely Subject: Re: [PATCH v3] leds: implement OpenFirmare GPIO LED driver Message-ID: <20080717141335.GA2219@polina.dev.rtsoft.ru> References: <1216133032.5345.73.camel@dax.rpnet.com> <20080715151917.GA30607@polina.dev.rtsoft.ru> <20080717041531.GA27243@secretlab.ca> <20080717140519.GA32617@polina.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 In-Reply-To: <20080717140519.GA32617@polina.dev.rtsoft.ru> Cc: Stephen Rothwell , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Richard Purdie , Trent Piepho Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jul 17, 2008 at 06:05:19PM +0400, Anton Vorontsov wrote: [...] > > I think it would be better to have a module that scans the device tree > > for LED nodes and registers a single leds-gpio platform device for the > > whole lot. > > > > Thoughts? > > I like the idea, thanks. Ugh, no. The idea sounds good, but in practice it isn't, since we'll have to handle suspend/resume ops ourselves. When we stick with the device/driver model we're getting all this for free. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2