From: Joel Becker Date: Fri, 18 Jul 2008 15:22:14 -0700 Subject: [Ocfs2-devel] [git patches] Ocfs2 and Configfs updates for 2.6.27 In-Reply-To: <20080718084803.GB3887@localdomain> References: <20080717175146.GH28014@wotan.suse.de> <20080717212038.GA8283@ca-server1.us.oracle.com> <20080717214512.GB8283@ca-server1.us.oracle.com> <20080717223018.GC8283@ca-server1.us.oracle.com> <20080718084803.GB3887@localdomain> Message-ID: <20080718222214.GB659@ca-server1.us.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Louis Rilling Cc: Joel.Becker@localdomain, Linus Torvalds , Mark Fasheh , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Andrew Morton On Fri, Jul 18, 2008 at 10:48:03AM +0200, Louis Rilling wrote: > > Linus, > > Pull this to get the revert and the PTR_ERR() version: > > > > git://oss.oracle.com/git/jlbec/linux-2.6.git configfs-fixup-ptr-error > > > > It's tested with the same testing I did before - ocfs2 and netconsole. > > While this new version looks ok, it seems that it still allows client > subsystems to return NULL in ->make_group()/->make_item(), in which case > configfs_mkdir() turns the result into -ENOMEM. Maybe this is intended to > smoothly update out-of-tree subsystems? I'd suggest to schedule a removal > of this backward compatibility, and display an error log to encourage > fixing the subsystems that still return NULL. It is precisely to keep out-of-tree modules from crashing. There's no easy way to make them know it changed otherwise :-) It could certainly BUG or WARN before making the fixup. Joel -- "I'm drifting and drifting Just like a ship out on the sea. Cause I ain't got nobody, baby, In this world to care for me." Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127