From: Tony Breeds Date: Thu, 24 Jul 2008 01:49:15 +0000 Subject: Re: [PATCH 4/6] kvmppc: magic page hypercall - host part Message-Id: <20080724014914.GK20457@bakeyournoodle.com> List-Id: References: <1216802207-32675-1-git-send-email-ehrhardt@linux.vnet.ibm.com> <1216802207-32675-5-git-send-email-ehrhardt@linux.vnet.ibm.com> In-Reply-To: <1216802207-32675-5-git-send-email-ehrhardt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ehrhardt@linux.vnet.ibm.com Cc: linuxppc-dev@ozlabs.org, embedded-hypervisor@power.org, hollisb@us.ibm.com, kvm-ppc@vger.kernel.org On Wed, Jul 23, 2008 at 10:36:45AM +0200, ehrhardt@linux.vnet.ibm.com wrote: Hi Christian, > long kvm_arch_dev_ioctl(struct file *filp, > unsigned int ioctl, unsigned long arg) > { > - return -EINVAL; > + long r = -EINVAL; > + > + switch (ioctl) { > + case KVM_GET_PPCPV_MAGICPAGE_SIZE: > + r = -EINVAL; Not needed you set it on the declaration. > + if (arg) > + goto out; > + r = 1024; Ummm what does 1024 represent? can it me #defined? or at least add a comment. > + break; > + default: > + r = -EINVAL; Not needed you set it on the declaration. > + } > +out: > + return r; > } Yours Tony linux.conf.au http://www.marchsouth.org/ Jan 19 - 24 2009 The Australian Linux Technical Conference!