From: Mark Brown Subject: Re: [PATCH] Permit simultaneous compilation of both PXA AC97 drivers Date: Sat, 26 Jul 2008 12:06:27 +0100 Message-ID: <20080726110626.GC3215@sirena.org.uk> References: <1217022714-2521-1-git-send-email-dbaryshkov@gmail.com> <20080725221517.GA5107@doriath.ww600.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id D939D246E4 for ; Sat, 26 Jul 2008 13:06:35 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20080725221517.GA5107@doriath.ww600.siemens.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Dmitry Baryshkov Cc: alsa-devel@alsa-project.org, eric.miao@marvell.com, rmk@arm.linux.org.uk List-Id: alsa-devel@alsa-project.org On Sat, Jul 26, 2008 at 02:15:17AM +0400, Dmitry Baryshkov wrote: > I should have said, that these patches are largely untested. Please test > before applying. Yeah, unfortunately it's kind of hard to get good test coverage due to the number of variants :/ . On the basis of the diffs these patches look good, though the volume of code motion means that I'll do another pass later. I'll also test with the hardware I have and then push up to Takashi (assuming I don't spot any issues) - it may be the middle of next week before that happens. Other test reports would be appreciated. This is certainly a very welcome cleanup - thanks a lot for doing it!