From: David Brownell Subject: Re: [patch 2.6.26+] spi: new orion_spi driver Date: Mon, 28 Jul 2008 23:43:24 -0700 Message-ID: <200807282343.25058.david-b@pacbell.net> References: <200807221228.00958.david-b@pacbell.net> <20080728211655.4d51e921.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Nicolas Pitre , Shadi Ammouri , saeed , Lennert Buijtenhek To: Andrew Morton Return-path: In-Reply-To: <20080728211655.4d51e921.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Monday 28 July 2008, Andrew Morton wrote: > > + > > +=A0=A0=A0=A0=A0if (orion_spi_baudrate_set(spi, speed) !=3D 0) > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -EINVAL; > > + > > +=A0=A0=A0=A0=A0if (orion_spi_set_transfer_size(orion_spi, bits_per_wor= d) !=3D 0) > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -EINVAL; > = > Given that orion_spi_baudrate_set() and orion_spi_set_transfer_size() > carefully return an -EFOO value, it's a bit unkind to just rub that out > and return a hard-coded -EINVAL. Right; I suppose I was so glad to see the previous issue fixed that I ended up overlookig that one! Shadi ... can you provide updates for these issues? - Dave > > ... > > > > +static void __exit orion_spi_exit(void) > > +{ > > +=A0=A0=A0=A0=A0platform_driver_unregister(&orion_spi_driver); > > + > > +=A0=A0=A0=A0=A0destroy_workqueue(orion_spi_wq); > > +} > = > Please double-check the workqueue handling. =A0Without looking at it too > closely, I think that this is waaaay too late to be running > destroy_workqueue(). =A0If a work is still pending, all the data upon > which it will be operating will have been rubbed out. =A0I'm suspecting > that an earlier flush_work() (or similar) will be needed. > = ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great priz= es Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=3D100&url=3D/