Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQ1xE-00028J-32 for mharc-grub-devel@gnu.org; Mon, 04 Aug 2008 11:26:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQ1xB-00027r-Tp for grub-devel@gnu.org; Mon, 04 Aug 2008 11:26:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQ1xA-00027f-ET for grub-devel@gnu.org; Mon, 04 Aug 2008 11:26:33 -0400 Received: from [199.232.76.173] (port=38028 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQ1xA-00027c-CV for grub-devel@gnu.org; Mon, 04 Aug 2008 11:26:32 -0400 Received: from aybabtu.com ([69.60.117.155]:53750) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KQ1xA-0007w4-5u for grub-devel@gnu.org; Mon, 04 Aug 2008 11:26:32 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KQ1px-0006Mf-N6 for grub-devel@gnu.org; Mon, 04 Aug 2008 17:19:05 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KQ1w7-0005KE-Tn for grub-devel@gnu.org; Mon, 04 Aug 2008 17:25:27 +0200 Date: Mon, 4 Aug 2008 17:25:27 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080804152527.GA20427@thorin> References: <20080804114833.GA3724@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080804114833.GA3724@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] power management on coreboot X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2008 15:26:34 -0000 On Mon, Aug 04, 2008 at 01:48:33PM +0200, Robert Millan wrote: > + /* Bochs, QEMU, etc. */ > + for (p = bochs_shutdown; *p || *(p-1); p++) > + grub_outb (*p, 0x8900); Ah, mistake here. This would continue if there's a \0 after the string terminator. I guess I'll have to add an explicit call after the loop. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."