From: Mark Brown Subject: Re: [PATCH 2/2] wm8750: add missing VREF output Date: Mon, 11 Aug 2008 11:42:14 +0100 Message-ID: <20080811104204.GC5560@sirena.org.uk> References: <1218444346-19153-1-git-send-email-dbaryshkov@gmail.com> <1218444346-19153-2-git-send-email-dbaryshkov@gmail.com> <20080811091119.GC9668@rakim.wolfsonmicro.main> <48A0025C.6000903@gmail.com> <20080811101939.GB5560@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 42A851037FE for ; Mon, 11 Aug 2008 12:42:17 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Dmitry Baryshkov , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, Aug 11, 2008 at 12:37:45PM +0200, Takashi Iwai wrote: > You mean both patches (spitz: MONO -> MONO1 and wm8750: add missing > VREF)? Anyway, a bit more detailed changelog is needed - what's > broken in the real use and how fixed. The long description is exactly what's broken - the names are wrong or undeclared and since DAPM works based on the control names this causes the drivers to fail to initialise DAPM for the device concerned. It's pretty much equivalent to C code referencing an undeclared variable. -- "You grabbed my hand and we fell into it, like a daydream - or a fever."