Date: Sat, 16 Aug 2008 14:51:47 +0200
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Message-ID: <20080816125147.GH6334@thorin>
References: <20080814191352.GA20823@thorin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080814191352.GA20823@thorin>
Organization: free as in freedom
User-Agent: Mutt/1.5.13 (2006-08-11)
Subject: Re: [PATCH] handle/report errors set by grub_device_iterate()
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>


Committed.  Same for disk/lvm.c as well.

On Thu, Aug 14, 2008 at 09:13:52PM +0200, Robert Millan wrote:
> 
> Hi,
> 
> After Felix's grub_print_error() fix, it is now possible to handle and
> report errors properly in raid.  This patch enables that.
> 
> -- 
> Robert Millan
> 
>   The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>   how) you may access your data; but nobody's threatening your freedom: we
>   still allow you to remove your data and not access it at all."

> 2008-08-14  Robert Millan  <rmh@aybabtu.com>
> 
> 	* disk/raid.c (grub_raid_init): Handle/report errors set by
> 	grub_device_iterate().
> 
> Index: disk/raid.c
> ===================================================================
> --- disk/raid.c	(revision 1806)
> +++ disk/raid.c	(working copy)
> @@ -580,6 +580,12 @@ static struct grub_disk_dev grub_raid_de
>  GRUB_MOD_INIT(raid)
>  {
>    grub_device_iterate (&grub_raid_scan_device);
> +  if (grub_errno)
> +    {
> +      grub_print_error ();
> +      grub_errno = GRUB_ERR_NONE;
> +    }
> +
>    grub_disk_dev_register (&grub_raid_dev);
>  }
>  

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."