Date: Mon, 18 Aug 2008 09:59:37 +0200
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -v3 6/7] kexec jump: __ftrace_enabled_save/restore
Message-ID: <20080818075937.GI30694@elte.hu>
References: <1218510876.24951.45.camel@caritas-dev.intel.com>
	<20080815124938.GB24663@elte.hu>
	<1219022293.5663.14.camel@yhuang-dev.sh.intel.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1219022293.5663.14.camel@yhuang-dev.sh.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: kexec-bounces@lists.infradead.org
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: Huang Ying <ying.huang@intel.com>
Cc: nigel@nigel.suspend2.net, Kexec Mailing List <kexec@lists.infradead.org>, linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>, "Rafael J. Wysocki" <rjw@sisk.pl>, "Eric W. Biederman" <ebiederm@xmission.com>, Pavel Machek <pavel@ucw.cz>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Vivek Goyal <vgoyal@redhat.com>


* Huang Ying <ying.huang@intel.com> wrote:

> On Fri, 2008-08-15 at 14:49 +0200, Ingo Molnar wrote:
> > * Huang Ying <ying.huang@intel.com> wrote:
> > 
> > > +/* Ftrace disable/restore without lock. Some synchronization mechanism
> > > + * must be used to prevent ftrace_enabled to be changed between
> > > + * disable/restore. */
> > 
> > use the proper comment style please:
> > 
> > /*
> >  *
> >  */
> 
> OK. I will change it.

it's upstream already, please send a followup clean up patch.

> > > +static inline int __ftrace_enabled_save(void)
> > > +{
> > > +#ifdef CONFIG_FTRACE
> > > +	int saved_ftrace_enabled = ftrace_enabled;
> > > +	ftrace_enabled = 0;
> > > +	return saved_ftrace_enabled;
> > > +#else
> > > +	return 0;
> > > +#endif
> > > +}
> > > +
> > > +static inline void __ftrace_enabled_restore(int enabled)
> > > +{
> > > +#ifdef CONFIG_FTRACE
> > > +	ftrace_enabled = enabled;
> > > +#endif
> > > +}
> > 
> > hm, what is this used for?
> > 
> > also, instead of such an ugly inline, why not create a proper 
> > kernel/trace/* function for this. That would also give it access to all 
> > the proper locking mechanisms - instead of relying on some extral 
> > mechanism.
> 
> This function is used for kexec jump in machine_kexec(). Where all 
> non-boot CPUs and IRQ are disabled, system is going to kexec, and it 
> is not allowed to schedule to other process in this circumstance, so a 
> non-lock version is needed. A locked version has been implemented by 
> Steven Rostedt, I think it can be used for other circumstance.

ok, fair enough.

	Ingo

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec