From: Wolfgang Denk Date: Tue, 19 Aug 2008 00:02:33 +0200 Subject: [U-Boot] [U-Boot-Users] [PATCH] (Resend)Allows negative offset in command loads In-Reply-To: <1217414369-28247-2-git-send-email-ricardo.ribalda@uam.es> References: <1217414369-28247-1-git-send-email-ricardo.ribalda@uam.es> <1217414369-28247-2-git-send-email-ricardo.ribalda@uam.es> Message-ID: <20080818220234.087FB24899@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ricardo Ribalda Delgado, In message <1217414369-28247-2-git-send-email-ricardo.ribalda@uam.es> you wrote: > > Signed-off-by: Ricardo Ribalda Delgado I think it makes little sense to change only one command and leave the other, similar commands unchanged. All commands that provide similar functions should behave the same. > Previus commit had compiling warnings > > common/cmd_load.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/common/cmd_load.c b/common/cmd_load.c > index 1b75a7b..ae56543 100644 > --- a/common/cmd_load.c > +++ b/common/cmd_load.c > @@ -38,7 +38,7 @@ static ulong load_serial_ymodem (ulong offset); ----------------------------------------------------^^^^^^^^^^^^^^ So this one should be changed, too? Maybe others as well? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Pardon me for breathing, which I never do anyway so I don't know why I bother to say it, oh God, I'm so depressed. Here's another of those self-satisfied doors. Life! Don't talk to me about life." - Marvin the Paranoid Android