From: Jens Axboe Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio? Date: Thu, 21 Aug 2008 07:26:05 +0200 Message-ID: <20080821052604.GM20055@kernel.dk> References: <48A5F5C6.2090204@redhat.com> <48ACAADD.2010104@sandeen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Milan Broz , Linux Kernel Mailing List , linux-fsdevel , Ric Wheeler , "MASON,CHRISTOPHER" To: Eric Sandeen Return-path: Content-Disposition: inline In-Reply-To: <48ACAADD.2010104@sandeen.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 20 2008, Eric Sandeen wrote: > Milan Broz wrote: > > Hi, > > > > I run some barrier tests over device-mapper (which currently doesn't > > support barrier bio at all) and even if I set barrier=1 in ext3 mount, > > there is never any bio with barrier flag... (in 2.6.27-rc) > > > > How is the barrier=1 flag supposed to work in ext3 (JBD) now? > > Milan, you're right. Ric saw this same strange behavior when doing some > benchmarking with and without barriers; Chris noticed the change in > submit_bh; I was about to write up a similar patch to what you've sent > already. Jens, does Milan's fix look good to you? Yep looks good, thanks a lot Milan! I'll send in the patch, unless I'm badly mistaken we need it for 2.6.26-stable as well. -- Jens Axboe