From: Wolfgang Denk Date: Tue, 02 Sep 2008 00:55:52 +0200 Subject: [U-Boot] [PATCH 1/1] device: clone device on register In-Reply-To: <20080901174820.432871d2@hskinnemo-gx745.norway.atmel.com> References: <48BBD4AE.5040806@denx.de> <1220281886-15794-1-git-send-email-plagnioj@jcrosoft.com> <20080901174820.432871d2@hskinnemo-gx745.norway.atmel.com> Message-ID: <20080901225552.70D16242FF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe, In message <20080901174820.432871d2@hskinnemo-gx745.norway.atmel.com> Haavard Skinnemoen wrote: > > > to prevent that the pointer will not be use for an other register > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Er. What? If a device is registered multiple times, that sounds like > something which should be fixed, not papered over like this... > > Btw, while I'm all for getting rid of common/lists.c, your cryptic > one-line commit message is a shooting offense to anyone who tries to > understand WTF is going on... I agree with Haavard on both accounts. Can you please look into this again? Thanks Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The human race is a race of cowards; and I am not only marching in that procession but carrying a banner. - Mark Twain