From: Mark Brown Subject: Re: [alsa-devel] [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec Date: Tue, 2 Sep 2008 19:54:32 +0100 Message-ID: <20080902185432.GA3553@sirena.org.uk> References: <1220306279-27977-1-git-send-email-sakoman@gmail.com> <1220306279-27977-2-git-send-email-sakoman@gmail.com> <1220306279-27977-3-git-send-email-sakoman@gmail.com> <20080902112633.GB25176@sirena.org.uk> <5e088bd90809020725g1d0dff70ue84f861ea3e22201@mail.gmail.com> <20080902145328.GA3764@rakim.wolfsonmicro.main> <5e088bd90809020936i2d5e8a12lee33acfe5cbd8cd6@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5e088bd90809020936i2d5e8a12lee33acfe5cbd8cd6@mail.gmail.com> Sender: linux-omap-owner@vger.kernel.org To: Steve Sakoman Cc: linux-omap@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Sep 02, 2008 at 09:36:29AM -0700, Steve Sakoman wrote: > The chip allows 19.2 Mhz, 26 Mhz, or 38.4 Mhz input clocks to the > codec. All existing boards (Overo, Beagle, and OMAP3 EVM) use 26 Mhz > (generated by a fixed external oscillator chip). I'll check with the > Pandora folks, but I believe that they are also 26 Mhz. OK, a comment to that effect somewhere (perhaps in set_sysclk() which only accepts 26MHz) probably wouldn't go amiss. Someone working on a board where the hardware guys went for a different crystal will probably thank you for it some day :)