From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 7 Sep 2008 01:05:46 +0200 Subject: [U-Boot] CFG_64BIT_xxx and friends In-Reply-To: <20080906231241.25260248BB@gemini.denx.de> References: <200809041609.26474.matthias.fuchs@esd-electronics.com> <20080906231241.25260248BB@gemini.denx.de> Message-ID: <20080906230546.GI1249@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01:12 Sun 07 Sep , Wolfgang Denk wrote: > Dear Matthias, > > in message <200809041609.26474.matthias.fuchs@esd-electronics.com> you wrote: > > > > after testing the recent U-Boot code on a couple of 405EP boards I noticed, > > that the memsize in the output of the "bdinfo" command is always 0x00000000. > > > > This is caused by using 64 types and format directives in printf that only > > work when CFG_64BIT_VSPRINTF is defined. > > Yeah, that's one more of these ugly bugs. > > > So what's the best way to fix this? > > Here are four solutions. My favorite is no. 2. > > > > 1) Define CFG_64BIT_STRTOUL for all effected board. > > Currently all 405 boards have memsize output as 0 in bdinfo. > > > > 2) Define CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL for all 4xx boards in > > include/ppc4xx.h: > ... > > 3) Generally define CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL for all boards. > > > > 4) Use an (ugly) workaround in common/cmd_bdinfo.c: > > I vote for # 5: > > 5) Delete al references to CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL > and unconditionally enable it for all boards. > > Any takers to submit a patch? If possible not because it will increase the size of u-boot for board which not need it. When we will have kconfig it will be simple to activated it for ppc and other board automaticly. Best Regards, J.