From: Frans Pop Subject: Re: [PATCH] sata_mv: enable active LED blink mode for SoC Date: Mon, 8 Sep 2008 16:25:29 +0200 Message-ID: <200809081625.31131.elendil@planet.nl> References: <12207863853449-git-send-email-saeed@marvell.com> <48C52B53.3030302@rtr.ca> <200809081616.03266.elendil@planet.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from hpsmtp-eml14.kpnxchange.com ([213.75.38.114]:56113 "EHLO hpsmtp-eml14.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbYIHOZd (ORCPT ); Mon, 8 Sep 2008 10:25:33 -0400 In-Reply-To: <200809081616.03266.elendil@planet.nl> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Saeed Bishara , linux-ide@vger.kernel.org, linux-arm@vger.kernel.org, jeff@garzik.org, grundler@google.com, buytenh@marvell.com, nico@marvell.com, tbm@cyrius.com On Monday 08 September 2008, Frans Pop wrote: > On Monday 08 September 2008, Mark Lord wrote: > > Frans Pop wrote: > > > So, IMO it is an improvement, but it is definitely not a fix for > > > the regression. > > > > With a new copy of hdparm, use "hdparm -Q1 /dev/sd?" > > Does that fix your "regression" ? > > $ sudo hdparm -Q1 /dev/sda > > /dev/sda: > setting queue_depth to 1 > queue_depth = 1 > > Yes, that does result in the original behavior of the led. > (Using version 8.9 of hdparm.) But that's not new information: we'd already determined some time ago that disabling NCQ "fixed" the problem, both if it is done at runtime and when it is disabled in the driver: http://www.spinics.net/lists/linux-ide/msg25642.html http://www.spinics.net/lists/linux-ide/msg25645.html