From: Nick Piggin Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch Date: Wed, 17 Sep 2008 00:11:21 +1000 Message-ID: <200809170011.22062.nickpiggin@yahoo.com.au> References: <476002.75149.qm@web26206.mail.ukl.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Hisashi Hifumi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Michael Trimarchi Return-path: In-Reply-To: <476002.75149.qm@web26206.mail.ukl.yahoo.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tuesday 16 September 2008 23:57, Michael Trimarchi wrote: > Hi, > > > > ----- Messaggio originale ----- > > > Da: Nick Piggin > > A: Michael Trimarchi > > Cc: Hisashi Hifumi ; > > akpm@linux-foundation.org; linux-kernel@vger.kernel.org; > > linux-fsdevel@vger.kernel.org Inviato: Marted=EC 16 settembre 2008, > > 14:54:21 > > Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit a= rch > > > > On Tuesday 16 September 2008 21:11, Michael Trimarchi wrote: > > > Hi, > > > > > > > + if (offset !=3D file_pos_read(file)) > > > > + file_pos_write(file, offset); > > > > retval =3D offset; > > > > } > > > > > > Is not more efficient here a compare xchg operation? > > > > The compiler should do it if it was. > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-ker= nel" > > in the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > i was thinking about introducing a file_pos_update() not implemented= using > file_pos_read()/file_pos_write() and taking the seq_lock or > disabling preemption only one time AFAIK, the only way to do an atomic 64 bit store on 32-bit x86 is "cmpxchg8b" (with lock prefix on SMP). That would be far slower I'm sure.