From: Jan-Bernd Themann Subject: Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption, eHCA is close Date: Tue, 23 Sep 2008 17:43:23 +0200 Message-ID: <200809231743.23828.ossthema@de.ibm.com> References: <20080915100406.342e027a@bull.net> <20080918143146.77db81d5@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Christoph Raisch , Benjamin Herrenschmidt , gilles.carry@ext.bull.net, Jan-Bernd Themann , jean-pierre.dion@bull.net, linux-kernel , Linux-rt , linux-ppc , netdev@vger.kernel.org, Thomas Q Klein , tinytim@us.ibm.com, Hoang-Nam Nguyen To: Sebastien Dugue Return-path: In-Reply-To: <20080918143146.77db81d5@bull.net> Content-Disposition: inline Sender: linux-rt-users-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi, I think these are the "functional" changes that need to be included in the ibmebus driver. We'll add a RT flag in the final version to enable these changes only for RT-Linux for now. Ben, can you / your team look into the implementation of the set_irq_type functionality needed for XICS? Regards, Jan-Bernd & Christoph diff -Nurp b/arch/powerpc/kernel/ibmebus.c a/arch/powerpc/kernel/ibmebus.c --- b/arch/powerpc/kernel/ibmebus.c 2008-09-22 00:29:55.000000000 +0200 +++ a/arch/powerpc/kernel/ibmebus.c 2008-09-23 12:04:53.000000000 +0200 @@ -216,12 +216,16 @@ int ibmebus_request_irq(u32 ist, irq_han unsigned long irq_flags, const char *devname, void *dev_id) { + int ret; unsigned int irq = irq_create_mapping(NULL, ist); if (irq == NO_IRQ) return -EINVAL; - return request_irq(irq, handler, irq_flags, devname, dev_id); + ret = request_irq(irq, handler, irq_flags, devname, dev_id); + set_irq_type(irq, IRQ_TYPE_EDGE_RISING); + + return ret; } EXPORT_SYMBOL(ibmebus_request_irq);