From: Mark Brown Subject: Re: [PATCH 1/1] ASoC Blackfin: add asoc ad73311 driver supporting in Blackfin boards Date: Sat, 27 Sep 2008 10:41:18 +0100 Message-ID: <20080927094117.GC3330@sirena.org.uk> References: <1222505943-22457-1-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id C60A310383C for ; Sat, 27 Sep 2008 11:41:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1222505943-22457-1-git-send-email-cooloney@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Bryan Wu Cc: alsa-devel@alsa-project.org, Cliff Cai List-Id: alsa-devel@alsa-project.org On Sat, Sep 27, 2008 at 04:59:03PM +0800, Bryan Wu wrote: > From: Cliff Cai > > Signed-off-by: Cliff Cai > Signed-off-by: Bryan Wu Acked-by: Mark Brown Looks good - one thing that might help people reading the changelogs for features might be to split out the I2S changes from the machine driver. As well as supporting the AD73311 machines this also makes the I2S driver more flexible which is a much more general feature and would be more clearly highlighted with a separate changelog entry. Thanks for the patches!