From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Date: Fri, 3 Oct 2008 17:03:31 +0200 Message-ID: <200810031703.32114.rjw@sisk.pl> References: <200808290002.55026.rjw@sisk.pl> <200810031327.19293.rjw@sisk.pl> <20081003054355.e3a3ac79.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:39938 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbYJCO7f (ORCPT ); Fri, 3 Oct 2008 10:59:35 -0400 In-Reply-To: <20081003054355.e3a3ac79.akpm@linux-foundation.org> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Andrew Morton Cc: Jeff Garzik , Tejun Heo , ACPI Devel Maling List , linux-ide@vger.kernel.org, Thomas Renninger , Robert Hancock , LKML , Frans Pop , Maciej Rutecki On Friday, 3 of October 2008, Andrew Morton wrote: > On Fri, 3 Oct 2008 13:27:18 +0200 "Rafael J. Wysocki" wrote: > > > > Can we just create a new global? > > > > > > extern bool system_entering_hibernation_or_whatever; > > > > Yes, we can, but what about: > > > > extern bool system_entering_hibernation(void); > > > > that will become a static inline in case of !CONFIG_HIBERNATION, > > and using a static variable? > > Sure, even better. OK, I'll respin the entire series, then.