Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kms2p-0003q5-DY for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:30:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kms2n-0003nH-Tt for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:30:47 -0400 Received: from [199.232.76.173] (port=56395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kms2n-0003n2-Ns for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:30:45 -0400 Received: from relay01.mx.bawue.net ([193.7.176.67]:42784) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kms2n-0004eK-8J for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:30:45 -0400 Date: Mon, 6 Oct 2008 17:30:33 +0200 From: Thiemo Seufer Subject: Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers Message-ID: <20081006153033.GB23799@networkno.de> References: <48EA0E22.4080302@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Jes Sorensen Johannes Schindelin wrote: > Hi, > > On Mon, 6 Oct 2008, Jes Sorensen wrote: > > > This patch simply converts all the machine structs to use C99 style > > initializers. There is no actual code change in this. > > Is it really such a good idea to do this? I mean, the only real change > you make here is to break compilation on compilers that do not grok C99 > (or do it badly). AFAICS Qemu is still stuck with GCC3 or later. Are you aware of a GCC 3.x version which is capable of building dyngen code but can't handle C99 initializers? Thiemo