From: Christoph Hellwig Subject: Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support. Date: Wed, 8 Oct 2008 09:00:06 -0400 Message-ID: <20081008130006.GB31684@infradead.org> References: <48BD47A8.1080909@bull.net> <20080902170148.GA9305@suse.de> <31436f4a0809032233r2c46de8od8a94460ce3b5ed2@mail.gmail.com> <48BF83E1.5040000@bull.net> <20081007164833.GA16056@suse.de> <20081007210902.GB7996@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org To: "Eric W. Biederman" Cc: Greg KH , Mark Ryden , Benjamin Thery , David Shwatrz , Greg KH , Andrew Morton , Tejun Heo , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , netdev@vger.kernel.org List-Id: containers.vger.kernel.org On Tue, Oct 07, 2008 at 03:27:12PM -0700, Eric W. Biederman wrote: > Al reviewed sysfs with my patchset on top of it. > > Al's review found problems in sysfs with my patchset on top of it. > > If you look at what Al found the majority of those problems exist in sysfs > without my patches. And when something is crap your fix it firdt before piling up more shit on top of it. And sysfs is a really severe case of that, and you're piling a _lot_ of shit ontop.