From: dcg Subject: [PATCH] Document file->f_pos as thread-unsafe Date: Fri, 10 Oct 2008 21:17:59 +0200 Message-ID: <20081010211759.630dfb6b@diego-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Peter Zijlstra , Hisashi Hifumi , torvalds@linux-foundation.org, Andrew Morton , Andi Kleen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Aneesh Kumar K.V" , Theodore Ts'o To: Nick Piggin Return-path: Received: from fg-out-1718.google.com ([72.14.220.152]:30197 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763108AbYJJTSH convert rfc822-to-8bit (ORCPT ); Fri, 10 Oct 2008 15:18:07 -0400 Received: by fg-out-1718.google.com with SMTP id 19so413442fgg.17 for ; Fri, 10 Oct 2008 12:18:05 -0700 (PDT) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: El Fri, 10 Oct 2008 13:25:15 +1100, Nick Piggin escribi=C3=B3: > Note that I don't think we'd want to explicitly guarantee that it is = atomic > on 64-bit machines either. It does happen to be, but I don't think we= want > anybody to rely on that... Easily fixable. Performance testing of this new version didn't find regressions. Document that it is not safe to play with file->f_pos from multiple pro= cesses if they aren't synchronizing themselves. Signed-off-by: Diego Calleja Index: 2.6/include/linux/fs.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- 2.6.orig/include/linux/fs.h 2008-10-10 21:07:29.000000000 +0200 +++ 2.6/include/linux/fs.h 2008-10-10 21:08:25.000000000 +0200 @@ -821,6 +821,17 @@ atomic_long_t f_count; unsigned int f_flags; mode_t f_mode; + /* + * Linux does NOT guarantee atomic reading/writing to file->f_pos in + * multithreaded apps. There're several reasons for this behaviour: + * - Specifications don't say it must be implemented that way. + * - This behaviour is part of the Linux semantics. + * - Any application that does multithreaded access to file->f_pos + * should be doing its own locking: the processes should synchroni= ze + * themselves when accessing a file descriptor. If an application + * doesn't do that, its file descriptor handling is buggy anyway a= nd + * must be fixed to do its accesses to file->f_pos properly. + */ loff_t f_pos; struct fown_struct f_owner; unsigned int f_uid, f_gid; -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html