From: Wolfgang Denk <wd@denx.de>
Date: Tue, 14 Oct 2008 18:25:44 +0200
Subject: [U-Boot] [PATCH] I2C: Fix CodingStyle issues in soft_i2c.c
In-Reply-To: <48E08A58.5060000@denx.de>
References: <48E08A58.5060000@denx.de>
Message-ID: <20081014162544.ABEAF81C99CD@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Heiko,

In message <48E08A58.5060000@denx.de> you wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>  drivers/i2c/soft_i2c.c |   24 ++++++++++++------------
...
> +#if defined(CONFIG_8xx) && !defined(CONFIG_MGSUVD)
>  	volatile immap_t *immr = (immap_t *)CFG_IMMR;
>  #endif

I cannot find any feedback from you fro my comment about this
non-coding style change. We don't want to add such  board specific
code in global files.

Can you please update and resubmit this patch? Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es gibt immer genug fuer die Beduerfnisse aller, aber  niemals  genug
fuer die Gier einzelner.                                    -- Ghandi