From: Ingo Molnar Subject: Re: [PATCH 8/15 v5] PCI: add boot options to reassign resources Date: Wed, 22 Oct 2008 09:19:09 +0200 Message-ID: <20081022071909.GB27637@elte.hu> References: <20081021114056.GA3185@yzhao12-linux.sh.intel.com> <20081021114959.GI3185@yzhao12-linux.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-pci@vger.kernel.org" , "jbarnes@virtuousgeek.org" , "randy.dunlap@oracle.com" , "grundler@parisc-linux.org" , "achiang@hp.com" , "matthew@wil.cx" , "rdreier@cisco.com" , "greg@kroah.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Yinghai Lu To: Yu Zhao Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:43739 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbYJVHTk (ORCPT ); Wed, 22 Oct 2008 03:19:40 -0400 Content-Disposition: inline In-Reply-To: <20081021114959.GI3185@yzhao12-linux.sh.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: * Yu Zhao wrote: > +static char *pci_assign_pio; > +static char *pci_assign_mmio; > + > +static int pcibios_bus_resource_needs_fixup(struct pci_bus *bus) > +{ > + int i; > + int type = 0; > + int domain, busnr; > + > + if (!bus->self) > + return 0; > + > + for (i = 0; i < 2; i++) { > + char *str = i ? pci_assign_pio : pci_assign_mmio; > + while (str && *str) { please put a newline after local variable defitions. > + for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) { > + struct resource *res = bus->resource[i]; > + if (!res) ditto. nice debug feature! Ingo