From: Nick Piggin Subject: Re: WARNING: at fs/buffer.c:1186 mark_buffer_dirty+0x51/0x66() Date: Tue, 28 Oct 2008 23:42:04 +1100 Message-ID: <200810282342.05172.nickpiggin@yahoo.com.au> References: <4901F375.3020202@vlnb.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org To: Vladislav Bolkhovitin Return-path: Received: from smtp106.mail.mud.yahoo.com ([209.191.85.216]:31429 "HELO smtp106.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751649AbYJ1MmV (ORCPT ); Tue, 28 Oct 2008 08:42:21 -0400 In-Reply-To: <4901F375.3020202@vlnb.net> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Saturday 25 October 2008 03:10, Vladislav Bolkhovitin wrote: > Hi, > > During recent debugging session of my SCSI target SCST > (http://scst.sf.net) I noticed many > > WARNING: at fs/buffer.c:1186 mark_buffer_dirty+0x51/0x66() > > messages in kernel log on the initiator. I attached the full log of > several of them. > > My target was buggy and I was working on fixing it, but I suppose Linux > should handle such failures more gracefully. In all the cases the target > had one type of failure: it "ate" a SCSI command and never returned > result of it. Right. This is one of the warnings I see in my fault-injection testing. It is fixed by my patch to clean up and improve the page and buffer error handling in the vm/fs.