From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Thu, 30 Oct 2008 11:21:16 +0100
Subject: [U-Boot] [PATCH 1/2] IOMUX: Add console multiplexing support.
In-Reply-To: <20081024142549.0d8c3023@ernst.jennejohn.org>
References: <20080914164107.32a9fce1@peedub.jennejohn.org>
	<20080914215939.GA9272@game.jcrosoft.org>
	<20080915110101.6b5e0a5b@peedub.jennejohn.org>
	<20081024111842.B3BCC810ED3B@gemini.denx.de>
	<20081024142549.0d8c3023@ernst.jennejohn.org>
Message-ID: <20081030102116.GA8767@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 14:25 Fri 24 Oct     , Gary Jennejohn wrote:
> On Fri, 24 Oct 2008 13:18:42 +0200
> Wolfgang Denk <wd@denx.de> wrote:
> 
> Dear Wolfgang,
> 
> > In message <20080915110101.6b5e0a5b@peedub.jennejohn.org> you wrote:
> > > On Sun, 14 Sep 2008 23:59:39 +0200
> > > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > >
> > > > > +#if defined(CONFIG_IO_MUX)
> > > > > +/** Console I/O multiplexing *******************************************/
> > > > > +
> > > > > +static device_t *tstcdev;
> > > > > +device_t *console_devices[MAX_FILES][MAX_CONSARGS];
> > > >
> > > > please use a list_head instead
> > > >
> > >
> > > This is an excellent suggestion.  Thanks!
> >
> > I understood that you would repost a new, modified patch which uses
> > this suggestion, but I haven't seen any repost sice.
> >
> > You know that the merge window is open right now - do you plan to
> > repost this stuff any time soon?
> >
> 
> I actually solved the problem by using realloc() rather than using a
> list_head.
> 
> I've merged the console multiplexing stuff into HEAD but hesitate to
> post it because my previous patch (setting GD_FLG_DEVINIT) is still
> unresolved.
> 
> But if the window is now open I'll post the new patch without resolution
> of the other one.  However, this approach may well lead to an unusable
> U-Boot if the user wants to set nc as a console in the environment.
I think it's really important to use list_head in order to have no limitation
and more important not increse the u-boot.bin size.

Best Regards,
J.