From: Ingo Molnar Subject: Re: 2.6.27 - SMP enabled, but only 1 CPU Date: Thu, 6 Nov 2008 22:33:44 +0100 Message-ID: <20081106213344.GF24579@elte.hu> References: <48F3BC99.5040409@theshore.net> <490F5F50.7020704@theshore.net> <4910AD00.7040605@theshore.net> <4911BC52.7040905@theshore.net> <1225994697.12607.837.camel@zakaz.uk.xensource.com> <49134257.4000404@goop.org> <20081106211639.GA24579@elte.hu> <49136168.3040604@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <49136168.3040604@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , xen devel , Ian Campbell List-Id: xen-devel@lists.xenproject.org * Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: >> a "cleanup" impact line is only added if the change is not intended to >> have any side-effects whatsoever. >> >> We can drop it but it would be really nice to figure out what's going >> on. In a very quick late-night look i cannot see anything particularly >> weird about it, but based on the type of changes it does there are >> three leading candidates: lost high 32 bits, zero extend problem, or >> incorrect types. > > Interestingly, the Xen code appears to be the *only* user of > pud_page - and only via pgd_page in PAE mode. where exactly is that use? My grep didnt show any users of pud_page(). pud_page() was changed in an incompatible way, all users of it must be updated. Ingo