From: Ingo Molnar Subject: Re: 2.6.27 - SMP enabled, but only 1 CPU Date: Thu, 6 Nov 2008 23:20:39 +0100 Message-ID: <20081106222039.GA7505@elte.hu> References: <48F3BC99.5040409@theshore.net> <490F5F50.7020704@theshore.net> <4910AD00.7040605@theshore.net> <4911BC52.7040905@theshore.net> <1225994697.12607.837.camel@zakaz.uk.xensource.com> <49134257.4000404@goop.org> <20081106211639.GA24579@elte.hu> <49136168.3040604@goop.org> <20081106213344.GF24579@elte.hu> <49136628.1020000@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <49136628.1020000@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , xen devel , Ian Campbell List-Id: xen-devel@lists.xenproject.org * Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: >> where exactly is that use? My grep didnt show any users of pud_page(). >> pud_page() was changed in an incompatible way, all users of it must be >> updated. >> > > pgd_page() uses it in pgtable-nopud.h, so any users of pgd_page() > also need to be looked at. It so happens the only user is > arch/x86/xen/mmu.c, which expects it to return the vaddr. Fixed > below. ah! asm-generic was missed by my grep. (and i suspect Jan missed it too) > Subject: xen: fix use of pgd_page now that it really does return a page applied to tip/x86/urgent, thanks! Ingo