From: Brad Boyer Subject: Re: [PATCH] Fix header include. Date: Wed, 19 Nov 2008 15:01:15 -0800 Message-ID: <20081119230115.GA21049@cynthia.pants.nu> References: <1226437008-14247-1-git-send-email-wt@penguintechs.org> <1226437008-14247-2-git-send-email-wt@penguintechs.org> <1226437008-14247-3-git-send-email-wt@penguintechs.org> <1226437008-14247-4-git-send-email-wt@penguintechs.org> <20081119145140.32828903.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Warren Turkal , linux-fsdevel@vger.kernel.org, zippel@linux-m68k.org To: Andrew Morton Return-path: Received: from [76.245.85.235] ([76.245.85.235]:37632 "EHLO cynthia.pants.nu" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751395AbYKSXBv (ORCPT ); Wed, 19 Nov 2008 18:01:51 -0500 Content-Disposition: inline In-Reply-To: <20081119145140.32828903.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote: > again: what was wrong with the old code?? > > If it was causing some compilation problem then please quote the compiler > output in the changelog. I didn't write this patch, but I was the original author of this driver. The issue here is that Apple added a journal feature after the fact and the current Linux driver doesn't support that. The current code just checks for the equivalent of a feature bit, while this change makes it also confirm that there really is a journal file. Without this change, an HFS+ file system that has been setup to do transactional changes but doesn't currently have an actual journal file allocated will not be mountable with the Linux driver. Just as a side note, although I am the original author I have never claimed to maintain this code. In fact, I wasn't the one that submitted it for inclusion. In any case, I don't plan on adding myself as maintainer. Brad Boyer flar@allandria.com