From: Brad Boyer Subject: Re: [PATCH] Fix header include. Date: Wed, 19 Nov 2008 16:41:50 -0800 Message-ID: <20081120004150.GA22395@cynthia.pants.nu> References: <1226437008-14247-1-git-send-email-wt@penguintechs.org> <1226437008-14247-2-git-send-email-wt@penguintechs.org> <1226437008-14247-3-git-send-email-wt@penguintechs.org> <1226437008-14247-4-git-send-email-wt@penguintechs.org> <20081119145140.32828903.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Warren Turkal , linux-fsdevel@vger.kernel.org, zippel@linux-m68k.org To: Andrew Morton Return-path: Received: from [76.245.85.235] ([76.245.85.235]:44922 "EHLO cynthia.pants.nu" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753704AbYKTAmC (ORCPT ); Wed, 19 Nov 2008 19:42:02 -0500 Content-Disposition: inline In-Reply-To: <20081119145140.32828903.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote: > On Tue, 11 Nov 2008 12:56:48 -0800 > Warren Turkal wrote: > > @@ -15,12 +15,12 @@ > > #include > > #include > > > > +#include "hfsplus_fs.h" > > + > > static struct inode *hfsplus_alloc_inode(struct super_block *sb); > > static void hfsplus_destroy_inode(struct inode *inode); > > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr); > > > > -#include "hfsplus_fs.h" > > - > > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr) > > { > > return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) && > > again: what was wrong with the old code?? I just realized what you were asking after I sent my other reply. The include needs to move so 'struct hfsplus_vh' is declared before the function prototype. That happens in hfsplus_fs.h. My apologies for the noise, although I stand by my statement that I have no intention of actively maintaining this code myself. > If it was causing some compilation problem then please quote the compiler > output in the changelog. The original submitter would need to include the actual compiler output. Brad Boyer flar@allandria.com