Return-Path: From: Arnd Bergmann To: Benjamin Herrenschmidt Subject: Re: [PATCH] powerpc/mpic: don't reset affinity for secondary MPIC on boot Date: Fri, 21 Nov 2008 15:40:02 +0100 References: <200811191450.59361.arnd@arndb.de> <200811201823.25263.arnd@arndb.de> <1227235450.7185.214.camel@pasglop> In-Reply-To: <1227235450.7185.214.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Message-Id: <200811211540.03281.arnd@arndb.de> Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, kexec@lists.infradead.org, cbe-oss-dev@ozlabs.org, Max Krasnyansky List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 21 November 2008, Benjamin Herrenschmidt wrote: > Oh just that for powermac for example, I know I'm resetting the thing, > so can't rely on init values, and on some BML embedded boxes too, while > on things like cell I don't off hand know what the right CPU number is > to hit the right C3PO interrupt, so I'm better off reading what SLOF > did :-) The current code will always use destination 0 for any MPIC, because mpic_init is run befew smp_init and it currently uses the local CPU. If an SMP powermac requires a specific destination setting in the secondary MPIC, either the current mpic_init code is broken there in the same way as on cell, or more broken if it requires something other than destination 0. > But if you think on Cell we can just hard wire in the platform code, > then I'm ok. On cell, I know that destination 0 is always correct because of the wiring inside of Axon. Arnd <><