From: Andrew Morton Subject: Re: [patch 2.6.8-rc6 2/3] spi: fix spi_s3c24xx_gpio num_chipselect Date: Sat, 22 Nov 2008 13:17:50 -0800 Message-ID: <20081122131750.e1c031e2.akpm@linux-foundation.org> References: <200811221219.12473.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Ben Dooks To: David Brownell Return-path: In-Reply-To: <200811221219.12473.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sat, 22 Nov 2008 12:19:12 -0800 David Brownell wrote: > From: Ben Dooks > > The spi master driver must have num_chipselect set to > allow the bus to initialise. Pass this through the > platform data. > > Signed-off-by: Ben Dooks > Signed-off-by: David Brownell > --- > arch/arm/mach-s3c2410/include/mach/spi-gpio.h | 1 + > drivers/spi/spi_s3c24xx_gpio.c | 1 + > 2 files changed, 2 insertions(+) > > --- a/arch/arm/mach-s3c2410/include/mach/spi-gpio.h > +++ b/arch/arm/mach-s3c2410/include/mach/spi-gpio.h > @@ -18,6 +18,7 @@ struct s3c2410_spigpio_info { > unsigned long pin_mosi; > unsigned long pin_miso; > > + int num_chipselect; > int bus_num; > > void (*chip_select)(struct s3c2410_spigpio_info *spi, int cs); > --- a/drivers/spi/spi_s3c24xx_gpio.c > +++ b/drivers/spi/spi_s3c24xx_gpio.c > @@ -118,6 +118,7 @@ static int s3c2410_spigpio_probe(struct > /* setup spi bitbang adaptor */ > sp->bitbang.master = spi_master_get(master); > sp->bitbang.master->bus_num = info->bus_num; > + sp->bitbang.master->num_chipselect = info->num_chipselect; > sp->bitbang.chipselect = s3c2410_spigpio_chipselect; > > sp->bitbang.txrx_word[SPI_MODE_0] = s3c2410_spigpio_txrx_mode0; What are the consequences of not having this fix in one's kernel? (ie: which kernel versions need this fix?) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/