From: Andrew Morton Subject: Re: [PATCH take2] do_mpage_readpage(): remove first_logical_block parameter Date: Sat, 29 Nov 2008 01:23:12 -0800 Message-ID: <20081129012312.b12127c2.akpm@linux-foundation.org> References: <492C6017.2070307@gmail.com> <20081125164803.952e9fd9.akpm@linux-foundation.org> <492DABE4.7010709@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Franck Bui-Huu Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:54306 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbYK2JXQ (ORCPT ); Sat, 29 Nov 2008 04:23:16 -0500 In-Reply-To: <492DABE4.7010709@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 26 Nov 2008 21:04:52 +0100 Franck Bui-Huu wrote: > This patch makes this function more readable IMHO by getting rid of > its parameter 'first_logical_block'. > > This parameter was previously used to remember the original block > number in the file (ie the page index) that 'map_bh' was pointing > at first. Indeed this was needed since 'map_bh->page' was modified > even if 'map_bh' maps the whole current page (IOW when get_block() > is not used). This had the bad effect to make the state of 'map_bh' > inconsistent too. Unfortunately we have a conflict with the already-queued do_mpage_readpage-dont-submit-lots-of-small-bios-on-boundary.patch: fs/mpage.c: In function 'do_mpage_readpage': fs/mpage.c:315: error: 'relative_block' undeclared (first use in this function) fs/mpage.c:315: error: (Each undeclared identifier is reported only once fs/mpage.c:315: error: for each function it appears in.) fs/mpage.c:315: error: 'first_logical_block' undeclared (first use in this function) fs/mpage.c:316: error: 'nblocks' undeclared (first use in this function) http://userweb.kernel.org/~akpm/mmotm/broken-out/do_mpage_readpage-dont-submit-lots-of-small-bios-on-boundary.patch