From: Christoph Hellwig Subject: Re: [PATCH] Update the exportfs documentation and comments and fix some exportfs issues Date: Wed, 3 Dec 2008 07:50:51 -0500 Message-ID: <20081203125051.GB4075@infradead.org> References: <20081202210233.19035.48005.stgit@warthog.procyon.org.uk> <49364304.7000501@lougher.demon.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Howells , hch@infradead.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: Phillip Lougher Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:58876 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002AbYLCMuy (ORCPT ); Wed, 3 Dec 2008 07:50:54 -0500 Content-Disposition: inline In-Reply-To: <49364304.7000501@lougher.demon.co.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Dec 03, 2008 at 08:27:48AM +0000, Phillip Lougher wrote: > You define these in the filesystem c files themselves as #defines. UDF > and BTRFS place theirs in the enum fid_type definition itself (in > linux/exportfs.h). Is there any reason why you didn't do this? The reason why the IDs for new filesystems go into exportfs.h to make sure they don't clash for different filesystems. While re-using the same ID to mean a different format is technically fine, it's not very nice for people trying to e.g. decipher NFS traffic in wireshark. Somewhere on my TODO list is an item to walk through all the filesystems and make them send out different IDs for new requests that don't overlap while still accepting their legacy IDs for traffic from the time before a server reboot.