From: Mike Frysinger Date: Thu, 11 Dec 2008 18:57:56 -0500 Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot In-Reply-To: <20081211235300.9C634808F6AD@gemini.denx.de> References: <20081211101257.29464834B020@gemini.denx.de> <200812111556.23044.vapier@gentoo.org> <20081211235300.9C634808F6AD@gemini.denx.de> Message-ID: <200812111857.57573.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 11 December 2008 18:53:00 Wolfgang Denk wrote: > In message Mike Frysinger you wrote: > > > Also, in the code you removed we do a runtime check on 8536 to see if > > > SATA is even available. That check is still valid. > > > > why ? if the hardware doesnt support it, then the user shouldnt be > > attempting to use it. if they do, that's their fault for doing something > > stupid. > > And if they do, the code should fail gracefully, i. e. print some > friendly error message like that S-ATA is not available. in this case, i think that's up to the controller. i.e. the controller doesnt find anything and you get a message that nothing was found. i dont have a board to test with to know what will happen exactly, nor does the current code make any statement that i can see. Scott ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20081211/d39a3496/attachment-0001.pgp