Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBotb-0006xt-MQ for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:12:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBota-0006xA-WF for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:12:23 -0500 Received: from [199.232.76.173] (port=49441 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBota-0006x2-E0 for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:12:22 -0500 Received: from hall.aurel32.net ([88.191.82.174]:45118) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBota-0003Pn-2r for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:12:22 -0500 Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b]) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1LBotY-0002CI-KJ for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:12:20 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1LBotX-0005J2-K4 for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:12:19 +0100 Date: Sun, 14 Dec 2008 12:12:19 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix fsel instruction Message-ID: <20081214111219.GJ17729@volta.aurel32.net> References: <20081214014910.GD23471@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20081214014910.GD23471@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, Dec 13, 2008 at 05:49:10PM -0800, Nathan Froyd wrote: > Fix fsel instruction. Eliminate unneeded temporaries while we're at it, > too. > > Signed-off-by: Nathan Froyd Thanks, applied. > --- > target-ppc/op_helper.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c > index a9b7f73..92c6269 100644 > --- a/target-ppc/op_helper.c > +++ b/target-ppc/op_helper.c > @@ -1592,16 +1592,14 @@ uint64_t helper_frsqrte (uint64_t arg) > /* fsel - fsel. */ > uint64_t helper_fsel (uint64_t arg1, uint64_t arg2, uint64_t arg3) > { > - CPU_DoubleU farg1, farg2, farg3; > + CPU_DoubleU farg1; > > farg1.ll = arg1; > - farg2.ll = arg2; > - farg3.ll = arg3; > > if (!fpisneg(farg1.d) || iszero(farg1.d)) > - return farg2.ll; > + return arg2; > else > - return farg2.ll; > + return arg3; > } > > uint32_t helper_fcmpu (uint64_t arg1, uint64_t arg2) > -- > 1.6.0.5 > > > > -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net