From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Wed, 17 Dec 2008 00:18:04 +0100
Subject: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1
In-Reply-To: <gi9a0g$q15$1@ger.gmane.org>
References: <49384721.wZiPCCd4SvLgYfJk%stefan.althoefer@web.de>
	<49384718.RDeSlY+9Cb0AIN+u%stefan.althoefer@web.de>
	<20081216215407.GI24266@game.jcrosoft.org>
	<gi9a0g$q15$1@ger.gmane.org>
Message-ID: <20081216231804.GL24266@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 23:28 Tue 16 Dec     , Stefan Althoefer wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
> > please use readx/writex 
> 
> The pointer dereference style is used throughout the
> other files in the IXP port as well. Shouldn't this
> be handled the same way in all files?
yes it's old wrong way code
for new we to use the good accessor

for old code patch are welcome

Best Regards,
J.