From: Ingo Molnar Subject: Re: [patch 1/7] ftrace: fix task state printout Date: Fri, 19 Dec 2008 22:36:41 +0100 Message-ID: <20081219213641.GB2351@elte.hu> References: <20081219155504.735865178@linutronix.de> <20081219155555.919550408@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Thomas Gleixner , LKML , Steven Rostedt , Peter Zijlstra , Clark Williams , Gregory Haskins , Linux-rt To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:42253 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbYLSVgz (ORCPT ); Fri, 19 Dec 2008 16:36:55 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-rt-users-owner@vger.kernel.org List-ID: * Fr=E9d=E9ric Weisbecker wrote: > Hi Thomas, >=20 > 2008/12/19 Thomas Gleixner : > > Impact: tracer task state decoding is wrong, size check is buggy > > > > The tracing code has interesting varieties of printing out task sta= te. > > Unfortunalely only one of the instances is correct as it copies the > > code from sched.c:sched_show_task(). The others are plain wrong as > > they treatthe bitfield as an integer offset into the character > > array. Also the size check of the character array is wrong as it > > includes the trailing \0. > > > > Use a common state decoder inline which does the Right Thing. > > > > Signed-off-by: Thomas Gleixner >=20 > You've already sent it out. It has been applied on -tip :-) That's why the subject line of the series says "2.6.24.7-rt24 bugfixes"= i=20 guess :-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html