From: Mike Frysinger Date: Tue, 23 Dec 2008 00:51:42 -0500 Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot In-Reply-To: <4941AD0A.40100@freescale.com> References: <20081211101257.29464834B020@gemini.denx.de> <200812111857.57573.vapier@gentoo.org> <4941AD0A.40100@freescale.com> Message-ID: <200812230051.43923.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 11 December 2008 19:15:06 Scott Wood wrote: > Mike Frysinger wrote: > > On Thursday 11 December 2008 18:53:00 Wolfgang Denk wrote: > >> And if they do, the code should fail gracefully, i. e. print some > >> friendly error message like that S-ATA is not available. > > > > in this case, i think that's up to the controller. i.e. the controller > > doesnt find anything and you get a message that nothing was found. > > > > i dont have a board to test with to know what will happen exactly, nor > > does the current code make any statement that i can see. Scott ? > > IIUC, if it's "not available" the driver will still see the controller > regs, but it will be trying to control pins that are actually routed to > another device. That said, it should be the driver calling into > SoC-specific code to find out, rather than a global SATA-blocker (what > if a PCIe SATA card were used?). i agree with that sentiment, but i'm not about to take on that restructure ;) -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20081223/995af0c1/attachment.pgp