From: David Brownell Subject: Re: [patch 2.6.28-rc9] spi: spi_write_then_read() regression fix Date: Tue, 23 Dec 2008 19:53:26 -0800 Message-ID: <200812231953.26407.david-b@pacbell.net> References: <200812202332.36281.david-b@pacbell.net> <200812231254.55284.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Andrew Morton , Vernon Sauder , Linus Torvalds To: "Tang, Feng" Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tuesday 23 December 2008, Tang, Feng wrote: > I'm writing a SPI-UART device driver for max3111, its working > mechanism is if you want read data back, you need write 0 to > it first ... > > The driver works in 2.6.27 with your previous spi_write_then_read() > implementation, but fails on 2.6.28 as it dumps all the readback > value of the write. And so it works with the $SUBJECT patch, yes? ------------------------------------------------------------------------------