From: Ingo Molnar Subject: Re: [PATCH 0 of 9] swiotlb: use phys_addr_t for pages Date: Sat, 27 Dec 2008 11:48:23 +0100 Message-ID: <20081227104823.GI14639@elte.hu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge , Tony Luck Cc: Xen-devel , Ian Campbell , Becky Bruce , the arch/x86 maintainers , linux-kernel@vger.kernel.org, FUJITA Tomonori List-Id: xen-devel@lists.xenproject.org * Jeremy Fitzhardinge wrote: > Hi all, > > Here's a work in progress series whcih does a partial revert of the > previous swiotlb changes, and does a partial replacement with Becky > Bruce's series. > > The most important difference is Becky's use of phys_addr_t rather than > page+offset to represent arbitrary pages. This turns out to be simpler. > > I didn't replicate the map_single_page changes, since I'm not exactly > sure of ppc's requirements here, and it seemed like something that could > be easily added. > > Quick testing showed no problems, but I haven't had the chance to do > anything extensive. > > I've made some small changes to Becky's patches to make them apply, but > I've separated any functional changes into separate patches with > appropriate authorship. looks good to me in principle. Fujita-san, do you have any principal objections against these generalizations? Also, this patch will interact with ia64 materially: Subject: [PATCH 9 of 9] ia64/x86/swiotlb: use enum dma_data_direciton in dma_ops So we'll need a bit more confidence in the testing status of this queue, and we probably want to wait until Tony merged the pending .29 ia64 changes, and also get an Ack from Tony for these bits: arch/ia64/dig/dig_vtd_iommu.c | 9 +++-- arch/ia64/hp/common/hwsw_iommu.c | 22 ++++++++------ arch/ia64/hp/common/sba_iommu.c | 12 ++++--- arch/ia64/include/asm/dma-mapping.h | 29 +++++++++--------- arch/ia64/include/asm/swiotlb.h | 26 ++++++++++------ arch/ia64/kernel/machvec.c | 6 ++- arch/ia64/sn/kernel/io_common.c | 3 +- arch/ia64/sn/pci/pci_dma.c | 21 ++++++++----- arch/ia64/sn/pci/pcibr/pcibr_dma.c | 3 +- arch/ia64/sn/pci/tioca_provider.c | 3 +- (Tony Cc:-ed) Ingo