From: Luis R. Rodriguez <lrodriguez@atheros.com>
Date: Mon, 29 Dec 2008 07:44:53 -0800
Subject: [ath9k-devel] [PATCH v3 02/16] ath9k: use hw->conf on
	ath_setcurmode()
In-Reply-To: <18776.21485.750323.652519@gargle.gargle.HOWL>
References: <1230076731-22946-1-git-send-email-lrodriguez@atheros.com>
	<1230076731-22946-2-git-send-email-lrodriguez@atheros.com>
	<1230076731-22946-3-git-send-email-lrodriguez@atheros.com>
	<18776.21485.750323.652519@gargle.gargle.HOWL>
Message-ID: <20081229154453.GP5944@tesla>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On Sun, Dec 28, 2008 at 08:37:01PM -0800, Sujith Manoharan wrote:
> Luis Rodriguez wrote:
> > +       switch (conf->channel->band) {
> > +       case IEEE80211_BAND_2GHZ:
> > +               if (conf_is_ht20(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NG_HT20];
> > +               else if (conf_is_ht40_minus(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NG_HT40MINUS];
> > +               else if (conf_is_ht40_plus(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NG_HT40PLUS];
> > +               else {
> > +                       sc->sc_protrix = 1;
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11G];
> > +               }
> > +               break;
> > +       case IEEE80211_BAND_5GHZ:
> > +               if (conf_is_ht20(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NA_HT20];
> > +               else if (conf_is_ht40_minus(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NA_HT40MINUS];
> > +               else if (conf_is_ht40_plus(conf))
> > +                       sc->cur_rate_table =
> > +                         sc->hw_rate_table[ATH9K_MODE_11NA_HT40PLUS];
> > +               else
> > +                       sc->cur_rate_table = sc->hw_rate_table[ATH9K_MODE_11A];
> > +               break;
> > +       default:
> > +               break;
> > +       }
> >  }
> 
> We don't have separate rate tables for ht20, ht40+, ht40-.
> Setting cur_rate_table just once using conf_is_ht() to any HT mode would suffice.

I do see we have different rate tables for these though, do you mean we can
consolidate on the rate tables?

  Luis