From: Ingo Molnar Date: Fri, 2 Jan 2009 20:58:02 +0100 Subject: [ath9k-devel] tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e) In-Reply-To: <495E6C96.3040102@kernel.org> References: <3f9a31f40901020936l4bed87e2jb64678572d2ad45b@mail.gmail.com> <20090102180730.GA10072@elte.hu> <3f9a31f40901021040l2afb5e19sc37e61d3f9728531@mail.gmail.com> <495E6C96.3040102@kernel.org> Message-ID: <20090102195802.GA28494@elte.hu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org * H. Peter Anvin wrote: > Jaswinder Singh Rajput wrote: > >> > >> diff --git a/drivers/net/wireless/ath9k/Kconfig b/drivers/net/wireless/ath9k/Kconfig > >> index c43bd32..b849a45 100644 > >> --- a/drivers/net/wireless/ath9k/Kconfig > >> +++ b/drivers/net/wireless/ath9k/Kconfig > >> @@ -1,6 +1,8 @@ > >> config ATH9K > >> tristate "Atheros 802.11n wireless cards support" > >> depends on PCI && MAC80211 && WLAN_80211 > >> + # build failures > >> + depends on 0 > >> select MAC80211_LEDS > >> select LEDS_CLASS > >> select NEW_LEDS > >> > > > > I thought the proper way to do this was "depends on BROKEN"... this was just a temporary hack to work around a mild regression in -git that i'm sure will be sorted out in short order (if it has not been already). CONFIG_BROKEN is a much different category: it blacklists ridiculously stale or mortally broken features/drivers, as a last warning before they get removed for good. I dont use it in such temporary, not-for-upstream testing hacks (even though the end result is obviously the same as 'depends on 0') - i didnt even have time to properly report the build breakage. Ingo