From: Alasdair G Kergon Subject: Re: Re: [git pull] device-mapper patches for 2.6.29 Date: Tue, 6 Jan 2009 03:48:45 +0000 Message-ID: <20090106034845.GD3512@agk.fab.redhat.com> References: <20081010125159.GK5098@agk.fab.redhat.com> <20090105191824.GP5098@agk.fab.redhat.com> <91b13c310901051915i38e05125tb89b3335922d274e@mail.gmail.com> <20090106032118.GC3512@agk.fab.redhat.com> <91b13c310901051932p1343f9eei1db5534e6e10d238@mail.gmail.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <91b13c310901051932p1343f9eei1db5534e6e10d238@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: crquan@gmail.com Cc: Kiyoshi Ueda , linux-kernel@vger.kernel.org, device-mapper development , Andi Kleen , Mikulas Patocka , Jun'ichi Nomura , Linus Torvalds , Milan Broz List-Id: dm-devel.ids On Tue, Jan 06, 2009 at 11:32:51AM +0800, Cheng Renquan (=E7=A8=8B=E4=BB=BB= =E5=85=A8) wrote: > On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon wro= te: > > On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (=E7=A8=8B=E4= =BB=BB=E5=85=A8) wrote: > >> So now maybe we can add a null macro to module_refcount if > >> CONFIG_MODULE_UNLOAD undefined? > > Do we even need the test at all? =20 > So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I > can do that, but I really don't know a better solution without > conditional compiling? =20 I mean under what set of circumstances could the test of the module refco= unt here fail, and if the test was simply removed are there any cases where t= hat would matter? Alasdair --=20 agk@redhat.com