Return-Path: Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by ozlabs.org (Postfix) with ESMTP id 19352474C5 for ; Tue, 6 Jan 2009 21:44:41 +1100 (EST) Date: Tue, 6 Jan 2009 11:46:19 +0100 From: Sam Ravnborg To: Kamalesh Babulal Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Message-ID: <20090106104619.GA13789@uranus.ravnborg.org> References: <5414eaef99b7392a95f6e3488b81dbf7@bga.com> <20090104182441.GA5086@linux.vnet.ibm.com> <98d6aef17cba9d835d7866745f811dc7@bga.com> <20090106072549.GA5066@linux.vnet.ibm.com> <20090106073149.GA12371@uranus.ravnborg.org> <20090106093847.GB5066@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20090106093847.GB5066@linux.vnet.ibm.com> Cc: linux-ppc , linux-kernel , Milton Miller , Stephen Rothwell List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Kamalesh Looks good, small nit below. > config VIOPATH > bool > - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH > - default y > + default n As 'n' is default anyway this line is not needed and I suggest you spin a final version of the patch with this removed. Sam