From: Russell King - ARM Linux Subject: Re: [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2 Date: Wed, 7 Jan 2009 22:00:53 +0000 Message-ID: <20090107220053.GD11471@n2100.arm.linux.org.uk> References: <20090107111415.GF27566@atomide.com> <20090107111615.GG27566@atomide.com> <20090107111744.GH27566@atomide.com> <20090107161843.GA11471@n2100.arm.linux.org.uk> <20090107175020.GU27566@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:59123 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756748AbZAGWBG (ORCPT ); Wed, 7 Jan 2009 17:01:06 -0500 Content-Disposition: inline In-Reply-To: <20090107175020.GU27566@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org, "Nikula Jarkko (NRC/Helsinki)" On Wed, Jan 07, 2009 at 07:50:21PM +0200, Tony Lindgren wrote: > * Russell King - ARM Linux [090107 18:18]: > > On Wed, Jan 07, 2009 at 01:17:45PM +0200, Tony Lindgren wrote: > > > - set_irq_type(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING); > > > - if (request_irq(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), &apollon_sw_interrupt, > > > + set_irq_type(gpio_to_irq(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING); > > > + if (request_irq(gpio_to_irq(SW_ENTER_GPIO16), &apollon_sw_interrupt, > > > > NAK. I wonder how the f*** this got anywhere near the mainline kernel. > > No no no no no. set_irq_type + request_irq is utter crap and should be > > rejected whenever its seen. There's absolutely no need for it - > > request_irq is sufficient. Get rid of this set_irq_type usage from > > everywhere please. > > Blind search and replace? :) I've removed the GPIO key code as there's > already a patch to do that cleaner with gpio_keys. Revised patch is fine.