From: Christian Borntraeger Subject: [PATCH 1/3 v2] kvm-s390: Fix printk on SIGP set arch Date: Thu, 22 Jan 2009 14:20:27 +0100 Message-ID: <200901221420.27403.borntraeger@de.ibm.com> References: <200901221026.13261.borntraeger@de.ibm.com> <20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com> <49785F81.3030704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Heiko Carstens , Carsten Otte , heicars2@linux.vnet.ibm.com, borntrae@linux.vnet.ibm.com, kvm@vger.kernel.org, Christian Ehrhardt , Olaf Schnapper To: Avi Kivity Return-path: Received: from mtagate4.de.ibm.com ([195.212.29.153]:53690 "EHLO mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbZAVNVG (ORCPT ); Thu, 22 Jan 2009 08:21:06 -0500 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id n0MDKS84019220 for ; Thu, 22 Jan 2009 13:20:28 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0MDKSLs3756228 for ; Thu, 22 Jan 2009 14:20:28 +0100 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0MDKS1M027445 for ; Thu, 22 Jan 2009 14:20:28 +0100 In-Reply-To: <49785F81.3030704@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Am Thursday 22 January 2009 12:58:57 schrieb Avi Kivity: > Right, either inject an exception to the guest (if appropriate for the > arch), or return -ESOMETHING from ioctl(KVM_RUN). Ok. What about: [PATCH] kvm-s390: fix printk on SIGP set arch From: Christian Borntraeger Reported-by: Heiko Carstens KVM on s390 does not support the ESA/390 architecture. We refuse to change the architecture mode and print a warning. This patch removes the printk for several reasons: o A malicious can flood host dmesg o The old message had no newline o there is no connection between the message and the failing guest This patch simply removes the printk. We already set the condition code to 3 - the guest knows that something went wrong. Signed-off-by: Christian Borntraeger --- arch/s390/kvm/sigp.c | 2 -- 1 file changed, 2 deletions(-) Index: kvm/arch/s390/kvm/sigp.c =================================================================== --- kvm.orig/arch/s390/kvm/sigp.c +++ kvm/arch/s390/kvm/sigp.c @@ -153,8 +153,6 @@ static int __sigp_set_arch(struct kvm_vc switch (parameter & 0xff) { case 0: - printk(KERN_WARNING "kvm: request to switch to ESA/390 mode" - " not supported"); rc = 3; /* not operational */ break; case 1: