Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LR80o-0007bj-Rw for mharc-grub-devel@gnu.org; Sun, 25 Jan 2009 11:39:06 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LR80m-0007aA-8U for grub-devel@gnu.org; Sun, 25 Jan 2009 11:39:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LR80l-0007ZA-BY for grub-devel@gnu.org; Sun, 25 Jan 2009 11:39:03 -0500 Received: from [199.232.76.173] (port=43150 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LR80l-0007Z0-8E for grub-devel@gnu.org; Sun, 25 Jan 2009 11:39:03 -0500 Received: from gateway05.websitewelcome.com ([67.18.144.2]:57982) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LR80k-0005Bd-Od for grub-devel@gnu.org; Sun, 25 Jan 2009 11:39:03 -0500 Received: (qmail 24062 invoked from network); 25 Jan 2009 16:55:52 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway05.websitewelcome.com with SMTP; 25 Jan 2009 16:55:52 -0000 Received: from [67.185.177.95] (port=45119 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1LR80Y-0000kW-NH; Sun, 25 Jan 2009 10:38:50 -0600 Date: Sun, 25 Jan 2009 08:38:48 -0800 From: Colin D Bennett To: The development of GRUB 2 Message-ID: <20090125083848.3db819a8@gibibit.com> In-Reply-To: <1232889809.28948.4.camel@localhost> References: <1232851143.23773.13.camel@localhost> <497C4046.4060907@nic.fi> <1232889809.28948.4.camel@localhost> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/pZa5=dg+3KWZz0dwlQOrKB_"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: lordhabbit@gmail.com Subject: Re: [PATCH] Build system improvement X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jan 2009 16:39:05 -0000 --Sig_/pZa5=dg+3KWZz0dwlQOrKB_ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 25 Jan 2009 14:23:29 +0100 Javier Mart=C3=ADn wrote: > El dom, 25-01-2009 a las 12:34 +0200, Vesa J=C3=A4=C3=A4skel=C3=A4inen es= cribi=C3=B3: > > Javier Mart=C3=ADn wrote: > > > This patch modifies several files in the build system (mainly common.= rmk > > > and genmk.rb) to reduce the general verbosity of the build process to= a > > > manageable, semi-informative level. Thus, what currently appears as > > > "gcc" calls, several lines long each is turned into lines like: > > >=20 > > > [M xfs.mod] COMPILE ../src/fs/xfs.c -> > > > xfs_mod-fs_xfs.o = = =20 > > > [M xfs.mod] LINK xfs_mod-fs_xfs.o -> > > > pre-xfs.o = = =20 > > > [M xfs.mod] Looking for EXPORTED SYMBOL definitions: pre-xfs.o > > >=20 > > > And so on. The change also makes warning-hunting marginally easier, > > > though not by much since the patch intentionally shows a line for nea= rly > > > every process that did so previously. This behavior could be simplifi= ed > > > further if needed - this post is more of an RFC than anything else. > > > Also, it is by no means thorough or complete - only the most common > > > processes have been addressed - as I'm a bit busy with exams. > > >=20 > > > The patch makes the new behavior the default one, so a new make-time > > > option is added: V (for "verbose"), which must have the value 1 in or= der > > > to get the behavior, as in "make V=3D1" > >=20 > > First of all I would like compiling process to be more tidier. > >=20 > > However, what is the difference between Colin's similar patch? > Oops... I did not remember Colin's patch, it's been so long since it was > last discussed that my mind considered it deceased for all intents and > purposes. I'll look into the post history and see what it did compared > to mine - if I get it to compile against a current SVN grub, that is. Basically the difference is that my 'prettymake' patch redefines the program variables like TARGET_CC, etc. so that they cause the echo of a nice like when they are executed. This is the main part of the patch (from Makefile.in) +### Pretty output control ### +# Set up compiler and linker commands that either is quiet (does not print +# the command line being executed) or verbose (print the command line). +_CC :=3D $(CC) +_TARGET_CC :=3D $(TARGET_CC) +_STRIP :=3D $(STRIP) +_GENMODSRC :=3D sh $(srcdir)/genmodsrc.sh +ifeq ($(V),1) + override V_PREFIX :=3D + override CC =3D $(_CC) + override TARGET_CC =3D $(_CC) + override STRIP =3D $(_STRIP) + override GENMODSRC =3D $(_GENMODSRC) + override INFO_GENCMDLIST =3D + override INFO_GENFSLIST =3D + override INFO_GENPARTMAPLIST =3D + override INFO_GEN_FINAL_COMMAND_LIST =3D + override INFO_GEN_FINAL_FS_LIST =3D + override INFO_GEN_FINAL_PARTMAP_LIST =3D +else + override V_PREFIX :=3D @ + override CC =3D @echo "COMPILE $<"; $(_CC) + override TARGET_CC =3D @echo "COMPILE(TARGET) $<"; $(_TARGET_CC) + override STRIP =3D @echo "STRIP $@"; $(_STRIP) + override GENMODSRC =3D @echo "GENMODSRC $@"; $(_GENMODSRC) + override INFO_GENCMDLIST =3D @echo "GENCMDLIST $@" + override INFO_GENFSLIST =3D @echo "GENFSLIST $@" + override INFO_GENPARTMAPLIST =3D @echo "GENPARTMAPLIST $@" + override INFO_GEN_FINAL_COMMAND_LIST =3D @echo "GENCMDLIST[final] $@" + override INFO_GEN_FINAL_FS_LIST =3D @echo "GENFSLIST[final] $@" + override INFO_GEN_FINAL_PARTMAP_LIST =3D @echo "GENPARTMAPLIST[final] $@" +endif I implemented it this way because it was easiest, since I didn't have to hunt down all the usages of the tools to add the output control. This method has downsides, and I think everyone will agree Javier's method is much more robust and more transparent as to what it is doing. Also, my patch no longer works, which shows its fragility: For instance, in current GRUB SVN the value of TARGET_CC is being referenced outside the context of actually executing it (its value is being assigned to another variable). This breaks with my patch because of the way TARGET_CC is redefined. If you want to see my whole patch (against older GRUB SVN -- it doesn't quite work against current GRUB for the reason mentioned above), you can see it at Regards, Colin --Sig_/pZa5=dg+3KWZz0dwlQOrKB_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEUEARECAAYFAkl8lZsACgkQokx8fzcGbYeT3QCYpzN50fgE6LwEkhcW2SeeRvZw ZwCaArSpzW46RUdmVoCD09CkZPqavEk= =XfQ4 -----END PGP SIGNATURE----- --Sig_/pZa5=dg+3KWZz0dwlQOrKB_--