From: Rusty Russell Subject: Re: [PATCH 4 of 7] x86/paravirt: selectively save/restore regs around pvops calls Date: Fri, 30 Jan 2009 10:57:27 +1030 Message-ID: <200901301057.28418.rusty@rustcorp.com.au> References: <200901291917.26601.rusty@rustcorp.com.au> <4981773A.1050403@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4981773A.1050403@goop.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Xen-devel , the arch/x86 maintainers , Ian Campbell , Zachary Amsden , Ravikiran Thirumalai List-Id: xen-devel@lists.xenproject.org On Thursday 29 January 2009 20:00:34 Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > It's kind of messy. Can we do something clever here with token pasting? > > I tried a few things, but no. Passing in just RAX, and then pasting > CLBR_##reg works, and the assembler accepts %RAX - but - the asm code > also #defines RAX , so the assembler ends up seeing > %48. I considered renaming all the CLBR_ defines to CLBR_rax, but that > looks unhappy too. So I stayed with this. OK, then Acked-by: Rusty Russell on this one too. Thanks, Rusty.